Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and additions to the copy parameters wrapper structure #593

Closed
eyalroz opened this issue Feb 27, 2024 · 0 comments
Closed

Fixes and additions to the copy parameters wrapper structure #593

eyalroz opened this issue Feb 27, 2024 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development

Comments

@eyalroz
Copy link
Owner

eyalroz commented Feb 27, 2024

The copy_parameters_t templated wrapper classes have a few issues:

  1. bytes_extent() is not implemented T_T
  2. Sometimes, people may set an endpoint and forget to set the transfer extent. Let's do it for them if it's not already set.
  3. set_source_untyped() delegates to set_endpoint somehow
@eyalroz eyalroz self-assigned this Feb 27, 2024
eyalroz added a commit that referenced this issue Feb 27, 2024
@eyalroz
Fixes #593: Copy parameters wrapper class work:
11a3501 
* Added the missing implementation of `bytes_extent()`
* When setting an endpoint, now also setting the extents, if they have not yet been sent
* `set_source_untyped()` now correctly delegates to `set_endpoint_untyped()`
eyalroz added a commit that referenced this issue Feb 27, 2024
@eyalroz
Fixes #593: Copy parameters wrapper class work:
8290b03 
* Added the missing implementation of `bytes_extent()`
* When setting an endpoint, now also setting the extents, if they have not yet been sent
* `set_source_untyped()` now correctly delegates to `set_endpoint_untyped()`
eyalroz added a commit that referenced this issue Feb 29, 2024
@eyalroz
Fixes #593: Copy parameters wrapper class work:
a71900d 
* Added the missing implementation of `bytes_extent()`
* When setting an endpoint, now also setting the extents, if they have not yet been sent
* `set_source_untyped()` now correctly delegates to `set_endpoint_untyped()`
eyalroz added a commit that referenced this issue Feb 29, 2024
@eyalroz
Fixes #593: Copy parameters wrapper class work:
4989d48 
* Added the missing implementation of `bytes_extent()`
* When setting an endpoint, now also setting the extents, if they have not yet been sent
* `set_source_untyped()` now correctly delegates to `set_endpoint_untyped()`
@eyalroz eyalroz closed this as completed in ae1747e Mar 1, 2024
eyalroz added a commit that referenced this issue Apr 20, 2024
@eyalroz
Fixes #593: Copy parameters wrapper class work:
c116985 
* Added the missing implementation of `bytes_extent()`
* When setting an endpoint, now also setting the extents, if they have not yet been sent
* `set_source_untyped()` now correctly delegates to `set_endpoint_untyped()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz