Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checking against the optional rather than the value in launch_config_builder_t #596

Closed
eyalroz opened this issue Mar 1, 2024 · 0 comments
Closed

Checking against the optional rather than the value in launch_config_builder_t #596

eyalroz opened this issue Mar 1, 2024 · 0 comments
Assignees
@eyalroz
Labels
bug resolved-on-development

Comments

@eyalroz
Copy link
Owner

eyalroz commented Mar 1, 2024

In launch_config_builder_t& kernel(const kernel_t* wrapped_kernel_ptr)

we currently check: if (device_ and kernel_->device_id() != device_) but the comparison should be against device_.value(), not device.
@eyalroz eyalroz added the bug label Mar 1, 2024
@eyalroz eyalroz self-assigned this Mar 1, 2024
eyalroz added a commit that referenced this issue Mar 1, 2024
@eyalroz
Fixes #596: launch_config_builder_t comparison against device id
d6a1aa6
eyalroz added a commit that referenced this issue Mar 1, 2024
@eyalroz
Fixes #596: launch_config_builder_t comparison against device id
bc8f1a3
eyalroz added a commit that referenced this issue Mar 1, 2024
@eyalroz
Fixes #596: launch_config_builder_t comparison against device id
b793999
eyalroz added a commit that referenced this issue Mar 8, 2024
@eyalroz
Fixes #596: launch_config_builder_t comparison against device id
6f29a2c
eyalroz added a commit that referenced this issue Mar 10, 2024
@eyalroz
Fixes #596: launch_config_builder_t comparison against device id
c679e6c
eyalroz added a commit that referenced this issue Mar 10, 2024
@eyalroz
Fixes #596: launch_config_builder_t comparison against device id
d476dde
eyalroz added a commit that referenced this issue Mar 10, 2024
@eyalroz
Fixes #596: launch_config_builder_t comparison against device id
806ec57
eyalroz added a commit that referenced this issue Mar 10, 2024
@eyalroz
Fixes #596: launch_config_builder_t comparison against device id
5523718
eyalroz added a commit that referenced this issue Apr 20, 2024
@eyalroz
Fixes #596: launch_config_builder_t comparison against device id
130cd01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
bug resolved-on-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz