Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace memory::external::mapped_region_t with unique_region, or rebase the former on the latter #617

Closed
eyalroz opened this issue Mar 18, 2024 · 1 comment
Closed

Replace memory::external::mapped_region_t with unique_region, or rebase the former on the latter #617

eyalroz opened this issue Mar 18, 2024 · 1 comment
Labels
enhancement resolved-on-development

Comments

@eyalroz
Copy link
Owner

eyalroz commented Mar 18, 2024

The memory::external::mapped_region_t class is pretty similar to a memory::unique_region. Perhaps we can replace the former with the latter, or at least make the latter a child class of the former.
eyalroz added a commit that referenced this issue Mar 18, 2024
@eyalroz
Fixes #617: Now using memory::unique_region instead of `memory::ext…
0cfcaa0 
…ernal::mapped_region_t`
@eyalroz
Copy link
Owner Author

eyalroz commented Mar 18, 2024

Completely clean replacement! Did not even have to correct a single command anywhere :-)

eyalroz added a commit that referenced this issue Mar 18, 2024
@eyalroz
Fixes #617: Now using memory::unique_region instead of `memory::ext…
0465bb2 
…ernal::mapped_region_t`
eyalroz added a commit that referenced this issue Mar 29, 2024
@eyalroz
Fixes #617: Now using memory::unique_region instead of `memory::ext…
74c3ad2 
…ernal::mapped_region_t`
eyalroz added a commit that referenced this issue Apr 20, 2024
@eyalroz
Fixes #617: Now using memory::unique_region instead of `memory::ext…
2ba88b3 
…ernal::mapped_region_t`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement resolved-on-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz