Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

link::marshalled_options_t and link::option_t should be in namespace detail_ #622

Closed
eyalroz opened this issue Mar 23, 2024 · 0 comments
Closed

link::marshalled_options_t and link::option_t should be in namespace detail_ #622

eyalroz opened this issue Mar 23, 2024 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Mar 23, 2024

Library users never actually need to know about JIToption's (and link::marshalled_options_t), nor about the CUjit_option - since they have our nice and convenient link::options_t class, which they can populate and pass around. Their only real use is internal, and thus - they shoud be placed in the detail_ namespace.
@eyalroz eyalroz added the task label Mar 23, 2024
@eyalroz eyalroz self-assigned this Mar 23, 2024
@eyalroz eyalroz changed the title link::marshalled_options_t and link::option_t should be in detail_ link::marshalled_options_t and link::option_t should be in namespace detail_ Mar 23, 2024
eyalroz added a commit that referenced this issue Mar 23, 2024
@eyalroz
Fixes #622: link::option_t and link::marshalled_options_t are now…
d488490 
… relegated to the `detail_` namespace
eyalroz added a commit that referenced this issue Mar 29, 2024
@eyalroz
Fixes #622: link::option_t and link::marshalled_options_t are now…
e6a703d 
… relegated to the `detail_` namespace
eyalroz added a commit that referenced this issue Apr 20, 2024
@eyalroz
Fixes #622: link::option_t and link::marshalled_options_t are now…
f477522 
… relegated to the `detail_` namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz