Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop examples/rtc_common.hpp, use cuda::rtc::render to print compilation options #631

Closed
eyalroz opened this issue Apr 8, 2024 · 0 comments

Comments

@eyalroz
Copy link
Owner

eyalroz commented Apr 8, 2024

The examples/rtc_common.hpp file only contains two functions, both regard printing compilation options. These are, in fact, unnecessary, since the wrappers offer cuda::rtc::render(), which gets us an std::string representation of the options. So, let's get rid of that code and its uses.

Note that this will remove the only use of cuda::rtc::marshalled_options_t in our example code.

@eyalroz eyalroz added the task label Apr 8, 2024
@eyalroz eyalroz self-assigned this Apr 8, 2024
eyalroz added a commit that referenced this issue Apr 8, 2024
…ctions and the `examples/rtc_common.hpp` header
eyalroz added a commit that referenced this issue Apr 8, 2024
eyalroz added a commit that referenced this issue Apr 12, 2024
…ctions and the `examples/rtc_common.hpp` header
eyalroz added a commit that referenced this issue Apr 12, 2024
eyalroz added a commit that referenced this issue Apr 13, 2024
…ctions and the `examples/rtc_common.hpp` header
eyalroz added a commit that referenced this issue Apr 13, 2024
eyalroz added a commit that referenced this issue Apr 20, 2024
…ctions and the `examples/rtc_common.hpp` header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant