Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move rtc::marshalled_options_t and rtc::marshal() into the detail_ subnamespace #632

Closed
eyalroz opened this issue Apr 8, 2024 · 0 comments
Closed

Move rtc::marshalled_options_t and rtc::marshal() into the detail_ subnamespace #632

eyalroz opened this issue Apr 8, 2024 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Apr 8, 2024

Users basically never need to use marshalled_options_t. The only sorta-kinda relevant scenario seems to involve printing, and that's taken care of by rtc::render(); see #630 . We can move it, and related code, into the detail_ subnamespace and non will be the wiser.
@eyalroz eyalroz added the task label Apr 8, 2024
@eyalroz eyalroz self-assigned this Apr 8, 2024
eyalroz added a commit that referenced this issue Apr 14, 2024
@eyalroz
Fixes #632: cuda::rtc::marshalled_options_t and related code are no…
132e3ea 
…w within the `detail_` subnamespace
eyalroz added a commit that referenced this issue Apr 20, 2024
@eyalroz
Fixes #632: cuda::rtc::marshalled_options_t and related code are no…
4c1b133 
…w within the `detail_` subnamespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz