Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor event_t similarly to the recent changes to stream_t #8

Closed
eyalroz opened this issue Nov 18, 2016 · 1 comment
Closed

Refactor event_t similarly to the recent changes to stream_t #8

eyalroz opened this issue Nov 18, 2016 · 1 comment
Assignees

Comments

@eyalroz
Copy link
Owner

eyalroz commented Nov 18, 2016

We've made stream_t only constructible with a stream id, and having a const id and device id - with stream::make() functions to call the creation code (which is outside of the class). Let's do the same for event_t (as well as keep their device IDs explicitly).

@eyalroz eyalroz self-assigned this Nov 18, 2016
@eyalroz eyalroz changed the title Make event_t more like stream_t Refactor event_t similarly to the recent changes to stream_t Nov 18, 2016
eyalroz pushed a commit that referenced this issue Nov 18, 2016
`event_t`:

* No longer caching the event flags in the wrapper; CUDA doesn't offer it - we don't offer it
* Made `event_t` only constructible when an event id already exists - which allows the construction to have the event id as a constant field
* Am caching the index of the device with which the stream is associated
* Added `make()` and `wrap()` methods a-la-`stream_t`
* Now destructing the `other` object on move-construction of an `event_`
@eyalroz
Copy link
Owner Author

eyalroz commented Nov 18, 2016

Why aren't events closed by commit comments? Hrumph.

@eyalroz eyalroz closed this as completed Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant