Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler warning triggered when compiling without -Wmaybe-uninitialized #167

Open
eyalroz opened this issue Nov 10, 2023 · 0 comments
Open
Labels
resolved-on-develop A changeset fixing this issue has been commiutted to the development branch task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Nov 10, 2023

This preprocessor directive:

#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"

on line 939 of src/printf/printf.c will fail if the option is unknown. It's known if you build with the provided CMakeLists.txt, but otherwise - it might not be, and we dopn't want:

src/printf/printf.c:659:32: warning: unknown warning group '-Wmaybe-uninitialized', ignored [-Wunknown-warning-option]
#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
                               ^
src/printf/printf.c:939:32: warning: unknown warning group '-Wmaybe-uninitialized', ignored [-Wunknown-warning-option]
#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"

littering our output.

@eyalroz eyalroz added resolved-on-develop A changeset fixing this issue has been commiutted to the development branch task labels Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolved-on-develop A changeset fixing this issue has been commiutted to the development branch task
Projects
None yet
Development

No branches or pull requests

1 participant