Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BUILD_SHARED_LIBS for choosing between static and shared build #174

Closed
eyalroz opened this issue Dec 19, 2023 · 0 comments
Closed

Use BUILD_SHARED_LIBS for choosing between static and shared build #174

eyalroz opened this issue Dec 19, 2023 · 0 comments
Labels
resolved-on-develop A changeset fixing this issue has been commiutted to the development branch

Comments

@eyalroz
Copy link
Owner

eyalroz commented Dec 19, 2023

CMake has built-in support for an option named BUILD_SHARED_LIBS for controlling whether libraries are built static or shared/dynamic by default. Let's use that instead of our custom BUILD_STATIC_LIBRARY.
eyalroz added a commit that referenced this issue Dec 19, 2023
@eyalroz
Fixes #174: Now utilizing the standard BUILD_SHARED_LIBS variable t…
af05afe 
…o control whether the library is built statically
@eyalroz eyalroz added the resolved-on-develop A changeset fixing this issue has been commiutted to the development branch label Dec 19, 2023
eyalroz added a commit that referenced this issue Jul 19, 2024
@eyalroz
Fixes #174: Now utilizing the standard BUILD_SHARED_LIBS variable t…
2ff0fd1 
…o control whether the library is built statically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
resolved-on-develop A changeset fixing this issue has been commiutted to the development branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz