Fixes #79: Integrate @joshklod's format attribute addition #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables compile-time error-checking of format strings and argument types w/ `-Wformat` (or `-Wall`)
- Correct type of `%h` arguments - Cast `%[jz]` arguments to the appropriate type instead of testing `sizeof(<type>)` at runtime - Suppress warnings from intentionally malformed format strings and `%b`, which is not recognized by GCC.
eyalroz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems Josh Klodnicki has fixed up the format string warnings following from his introduction of the
__attribute__(format)'s, so I can now safely (I hope) integrate his work.This will fix issue #79.