Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misra compliance #79

Closed
wants to merge 13 commits into from
Closed

Misra compliance #79

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
740b878
Rule 13.3 increment/decrement with other side effects
Dec 24, 2021
7398ba0
Merge collapsible if statements (not strictly MISRA)
Dec 24, 2021
e0aff68
Unmodified pointers should be const (MISRA C:2004, 16.7 )
Dec 26, 2021
62bcd9d
Removed redundant cast
Dec 26, 2021
f5c7327
MISRA C:2012, 20.1 - #include directives should only be preceded by p…
Dec 26, 2021
c43886f
Revert "Unmodified pointers should be const (MISRA C:2004, 16.7 )"
Dec 27, 2021
950c40e
MISRA C:2004, 16.9 - A function identifier shall only be used with ei…
Dec 27, 2021
7d74780
MISRA C++:2008, 18-0-1 - The C library shall not be used.
Dec 30, 2021
bee6c0d
MISRA C:2004, 19.10
Jan 2, 2022
a6cb311
MISRA C:2004, 6.3 - typedefs that indicate size and signedness should…
Jan 2, 2022
1dfd730
Change to size_t for internal strnlen return value
Jan 3, 2022
cdeac63
Split function declarations into standard and custom
Jan 5, 2022
a993682
Merge branch 'develop' into MISRA-compliance
sanderh255 Jan 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/printf/printf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,8 +589,9 @@ static size_t print_broken_up_decimal(
}
}
// add extra 0s
while ((len < PRINTF_FTOA_BUFFER_SIZE) && (count-- > 0U)) {
while ((len < PRINTF_FTOA_BUFFER_SIZE) && (count > 0U)) {
buf[len++] = '0';
--count;
}
if (len < PRINTF_FTOA_BUFFER_SIZE) {
buf[len++] = '.';
Expand Down Expand Up @@ -1055,8 +1056,9 @@ static int _vsnprintf(out_fct_type out, char* buffer, const size_t maxlen, const
}
}
// string output
while ((*p != 0) && (!(flags & FLAGS_PRECISION) || precision--)) {
while ((*p != 0) && (!(flags & FLAGS_PRECISION) || precision)) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this exactly equivalent?

What if there are no precision flags? In that case, with the new code, precision gets decremented while before it wasn't.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is true, but precision is only used to exit the while loop, so this does not impact any functionality.

out(*(p++), buffer, idx++, maxlen);
--precision;
}
// post padding
if (flags & FLAGS_LEFT) {
Expand Down