Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddOn not working on 115 #195

Open
lkasdj9 opened this issue Nov 12, 2023 · 9 comments
Open

AddOn not working on 115 #195

lkasdj9 opened this issue Nov 12, 2023 · 9 comments

Comments

@lkasdj9
Copy link

lkasdj9 commented Nov 12, 2023

Hi,
Currently i am on 115.4.2 but even on earlier 115 versions the add did not find any duplicates.
My settings are to compare Subject and Body, in matter of minutes.
Even when i tested with/without number of lines - not working....
I must compare both Subject and Body. During my tests - Subject alone works. Body alone does not work.
Am happy to make more tests.

@eyalroz
Copy link
Owner

eyalroz commented Sep 1, 2024

I'm sorry for the long delay in noticing this bug report.

Version 0.5.4b5 works with all Thunderbird 115.x versions; version 0.6.0 works with TB 128.x .

If you mean you're not finding duplicates - that is probably because your messages are almost-duplicates of each other. Message bodies often differ slightly, e.g. by an extra newline - and this can be due to differences in the way the "same" message is handled. I would recommend a different set of comparison criteria, and a careful check using the review dialog before actually deleting the messages.

@lkasdj9
Copy link
Author

lkasdj9 commented Sep 2, 2024 via email

@eyalroz
Copy link
Owner

eyalroz commented Sep 2, 2024

The thing is that the messages i have as duplicates arrive from websites and telephony systems so they are for sure duplicates.

They are what you would consider duplicates; but - they may in practice be slightly different. They may have different number of empty lines at the bottom; their send time may be slightly different; etc. Please start removing comparison criteria until you actually start to get duplicates, then add some back carefully so that you actually capture the messages you want to.

@lkasdj9
Copy link
Author

lkasdj9 commented Sep 2, 2024 via email

@eyalroz
Copy link
Owner

eyalroz commented Sep 2, 2024

The addon found them in the past with no problem...

Please attach an mbox file with a couple of such duplicates, which the add-on fails to find; or send it to me, zipped, and I'll check. But I very much doubt it, as the dupe identification logic has not changed in years, and users don't complain about it. When they do complain, it always ends up being the case of overly-strict comparison criteria.

@lkasdj9
Copy link
Author

lkasdj9 commented Sep 3, 2024 via email

@eyalroz
Copy link
Owner

eyalroz commented Sep 3, 2024

@lkasdj9 : First, please don't comment by replying to the email, since GitHub messages up the message and adds a lot of header content, and a copy of my own previous message... :-(

Anyway, can you possibly attach an mbox file with those two duplicate messages, for me to check? If not, could you possibly email such an mbox file, zipped, to me?

@lkasdj9
Copy link
Author

lkasdj9 commented Sep 4, 2024

Sent you the files via email. Thanks

@lkasdj9
Copy link
Author

lkasdj9 commented Sep 23, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants