You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In tests/facet_pack.cpp we have the test_constrained_fpe() function. It uses move and copy construction counting to check whether certain values are copied or moved - and we fail because there as some copies when there should be moves:
/home/eyalroz/src/mine/strf/test/facets_pack.cpp:384: test (1 == 0) failed.
In function 'void test_constrained_fpe()'
/home/eyalroz/src/mine/strf/test/facets_pack.cpp:387: test (2 == 0) failed.
In function 'void test_constrained_fpe()'
/home/eyalroz/src/mine/strf/test/facets_pack.cpp:390: test (3 == 0) failed.
In function 'void test_constrained_fpe()'
/home/eyalroz/src/mine/strf/test/facets_pack.cpp:393: test (4 == 0) failed.
In function 'void test_constrained_fpe()'
/home/eyalroz/src/mine/strf/test/facets_pack.cpp:396: test (5 == 0) failed.
In function 'void test_constrained_fpe()'
there are additional failures which may or may not be related to these.
The problem seems to be that a lot of move ctors for facet packs, which inherit from fact_pack_base - don't use std::move() when constructing their base class. Which apparently we need to do.
The text was updated successfully, but these errors were encountered:
* Using `std::move()` on base-class initializers for `fpe_wrapper`, `constrained_fpe`, `facts_pack`, `facet_pack_base.
* Removed two unused and invalid ctors for `facet_pack_base`.
In
tests/facet_pack.cpp
we have thetest_constrained_fpe()
function. It uses move and copy construction counting to check whether certain values are copied or moved - and we fail because there as some copies when there should be moves:there are additional failures which may or may not be related to these.
The problem seems to be that a lot of move ctors for facet packs, which inherit from fact_pack_base - don't use
std::move()
when constructing their base class. Which apparently we need to do.The text was updated successfully, but these errors were encountered: