-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What about CMake? #103
Comments
Cmake? co-ask. |
Acknowledged the ask, I will free some time for this but I can’t promise it’s soon because I see this as a nice to have |
It's a header only library, it doesn't need to "make" itself, so in my opinion cmake is not necessary.
You could replace the path with variable
Anyway, you need a way to find the library, even with cmake. |
CMake is needed for the test cases
…On Wed, Feb 15, 2023 at 9:27 AM Traveller ***@***.***> wrote:
It's a header only library, it doesn't need to "make" itself, so in my
opinion cmake is not necessary.
This is how I reference it in my cmake project:
target_include_directories(my_test SYSTEM PRIVATE C:/Libraries/zpp_bits)
You could replace the path with variable ${ZPP_BITS_PATH}, and then
provide this variable to the cmake command, for example:
-DZPP_BITS_PATH="C:/Libraries/zpp_bits"
Anyway, you need a way to find the library, even with cmake.
—
Reply to this email directly, view it on GitHub
<#103 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABISKGALY4OZVKV5LQT6543WXTRTHANCNFSM6AAAAAATVI5BY4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Well, indeed it is. |
But the test cases are not a dependency in your project |
not true if I want to learn the code and wish to contribute it, or
deeply customize it.
…------ Original Message ------
From "Eyal Z" ***@***.***>
To "eyalz800/zpp_bits" ***@***.***>
Cc "Wuping Xin" ***@***.***>; "Comment"
***@***.***>
Date 2/15/2023 5:01:43 PM
Subject Re: [eyalz800/zpp_bits] What about CMake? (Issue #103)
But the test cases are not a dependency in your project
—
Reply to this email directly, view it on GitHub
<#103 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABISKGA2FT2CINNM2PCDFZTWXVG4PANCNFSM6AAAAAATVI5BY4>.
You are receiving this because you commented.Message ID:
***@***.***>
|
Well, CMake might be overkill for header only library, but as @wxinix said, it'll be great to cover code by tests.
But the case that I really want to achieve is cloning project during configuration step. I usually use CPM for managing project's dependencies. And it's pretty uncomfortable for me to load and insert some third_party stuff to the project. I enjoy to load dependencies into the build folder, which is ignored by git 🍰 |
Closed due to inactivity, as mentioned in above comments cmake transparently works with header only. |
Would you like to add CMake support? It's not so hard for header-only library
You can use this tool for making cmake project just in a few commands
The text was updated successfully, but these errors were encountered: