Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmmlib lacks of find_package #43

Closed
adevress opened this issue Mar 2, 2016 · 3 comments
Closed

vmmlib lacks of find_package #43

adevress opened this issue Mar 2, 2016 · 3 comments
Assignees

Comments

@adevress
Copy link

adevress commented Mar 2, 2016

Vmmlib is the only component in the BBP/viz stack that does not install a cmake Target file by default.

Due to this it cannot be discovered automatically through common_package and is downloaded systematically, even if already installed or present inside the CMAKE_PREFIX_PATH

As vmmlib is an header only library and the target generation for header only library is buggy under cmake 2.8, would it be possible to include directly a find_package module file for vmmlib in CMake / Common ?

Adev

@eile eile self-assigned this Mar 3, 2016
@eile
Copy link
Member

eile commented Mar 3, 2016

Can't reproduce:

[tsf-484-wpa-2-061 Livre sortlast]% clear ; ninja -C ../build install
[...]
[tsf-484-wpa-2-061 Livre sortlast]% ls ../build/install/share/vmmlib/CMake/
options.cmake           vmmlibConfig.cmake      vmmlibConfigVersion.cmake   vmmlibTargets.cmake

@eile
Copy link
Member

eile commented Mar 3, 2016

You do need cmake 3 for this. We will make this mandatory as soon as Ubuntu 16.04 is out, so better get ready.

Let me know if you see any problem with this.

@eile eile closed this as completed Mar 3, 2016
@adevress
Copy link
Author

adevress commented Mar 3, 2016

That's fine for me, as long as it is consistent and we have cmake 3 everywhere, which should be the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants