This repository has been archived by the owner on Mar 26, 2021. It is now read-only.
Develop #103
Merged
Develop #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix calls without validate
log validation error use mimeType for POST
move postman tests
bump version to 2.0.0 update docs add regex to schema
|
@shrikster could you help review this? I think it's ready for release, but would like you opinion. |
|
Reviewing tomorrow 👍 @jgroom33 |
shrikster
reviewed
Nov 16, 2018
src/handler.ts
Outdated
| console.log(); | ||
| if(validateSchema.errors.length > 0) { | ||
| for (let erroredSchema of validateSchema.errors){ | ||
| console.log(JSON.stringify(erroredSchema.details, null, 2)); |
There was a problem hiding this comment.
maybe we should use console.error ?
There was a problem hiding this comment.
I updated this to use writeErrorMessage()
src/test.ts
Outdated
| }) | ||
|
|
||
| nunjucksEnv.addGlobal('Env', function (envi: string) { | ||
| let environ = process.env[envi] |
rename fail tests add schema failure
eykrehbein
reviewed
Nov 16, 2018
|
The raw object allows the file to be parsed by nunjucks as each new response object is saved.
This isn't really the way nunjucks was designed to be used, but it seems to work out. |
|
@eykrehbein any other topics to discuss? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready for review. It implements HAR as the schema.
... request: url: https://postman-echo.com/get method: GET queryString: - name: foo value: bar value2: request: url: https://postman-echo.com/get method: GET queryString: - name: baz value: <$ value1.content.args.foo $>Resolve #94
Resolve #97
Resolve #22