Skip to content
This repository has been archived by the owner on Mar 26, 2021. It is now read-only.

Issue 95 -add support for filename as parameter #124

Conversation

shrikster
Copy link
Contributor

Hi this PR solves Issue #95 , Add support for using the strest test filename as a parameter in the request .
I was a little bit more complicated than stated in the issue , due to the fact that the testObject.relativepath is not the file name , it's just the path to the file .
1.I have added fileName property on parse file object at yaml-parse.ts, and updated the schema .
2.Passes the file name to the computeRequestObject that uses the common practice of nunjucksEnv addGlobal to replace the Filname() string with the fileName
3.updated the readme
I have 2 Notes
1.I am removing the strest suffix from the file name - see the computeRequestObject function .
2.we need to consider using nodejs path.parse(filePath)
to get all the file parts .. (folder / root )

see this line in yaml-parse.ts
const {name:fileName} = path.parse(filePath);

Copy link
Collaborator

@jgroom33 jgroom33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR shows two identical files.
tests/success/file/postman-echo.strest.yml

Is that correct?

@shrikster
Copy link
Contributor Author

yes - they have different names ..

@shrikster
Copy link
Contributor Author

Can you merge ?

@jgroom33
Copy link
Collaborator

oh thanks... i did not notice that

@jgroom33 jgroom33 merged commit d8678c0 into eykrehbein:master Jan 22, 2019
@jgroom33 jgroom33 mentioned this pull request Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants