Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added swaybg support #28

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Added swaybg support #28

merged 1 commit into from
Jan 20, 2024

Conversation

eylles
Copy link
Owner

@eylles eylles commented Jan 20, 2024

pull request #711

@madstone0-0 just an interesting pattern i noticed both swaybg and swww take precedence before feh, my first thought is that is because a wayland environment could expect to find feh as part of xwayland and try to set the wallpaper there instead of where it should be setting it, no need to answer was just something i thought.

@eylles eylles merged commit de1e7e8 into master Jan 20, 2024
@madstone0-0
Copy link
Contributor

Yeah, swaybg taking precedence was personal preference as I use Hyprland and I don't think wallpaper changing with feh works. Also sorry about the typo. I've fixed it in my fork, but I'm still pretty new to collaborative git stuff, so I haven't figured out how to update my pull request.

@eylles
Copy link
Owner Author

eylles commented Jan 28, 2024

Eh don't worry, i'll just push the commit directly to master, gotta review every commit to master since last release before creating an new one anyway.

@eylles eylles deleted the swaybg-support branch May 7, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants