Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyO3 integration - offer to rehome #57

Closed
davidhewitt opened this issue Aug 24, 2021 · 2 comments
Closed

PyO3 integration - offer to rehome #57

davidhewitt opened this issue Aug 24, 2021 · 2 comments

Comments

@davidhewitt
Copy link

Hi,

Thanks for providing integration with PyO3!

Over in the PyO3 repo we're currently discussing accepting an anyhow optional feature. PyO3/pyo3#1822

I am aware that you've got the pyo3 optional feature; I was wondering if for symmetry you wanted us to take ownership of the eyre / pyo3 integration by adding an eyre optional feature to pyo3?

Presumably we can just copy the trait implementations you already have from this repo over to the PyO3 codebase.

@yaahc
Copy link
Collaborator

yaahc commented Aug 26, 2021

I was wondering if for symmetry you wanted us to take ownership of the eyre / pyo3 integration by adding an eyre optional feature to pyo3?

Sure!

@davidhewitt
Copy link
Author

@yaahc we've now merged an eyre feature into PyO3 and will probably release it in the next couple of weeks (PyO3/pyo3#1921). Feel free to close this ticket / update eyre as you see fit.

pksunkara pushed a commit that referenced this issue Oct 11, 2023
* (cargo-release) start next development iteration 0.5.3-alpha.0

* add support for customized panic messages

* reorg a little

* add example and changelog

* reorder items in example

* fix missing semi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants