Update documentation on no_std support. #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no_std support was removed in 2020 with PR eyre-rs#29. This change updates the documentation to reflect that as suggested in PR eyre-rs#89. It still mentions no_std, which will hopefully keep it on our minds enough to check sometimes and see if the upstream problem has been resolved.
jyn514
approved these changes
Nov 5, 2023
Comment on lines
+174
to
+176
| No-std support was removed in 2020 in [commit 608a16a] due to unaddressed upstream breakages. | ||
| [commit 608a16a]: | ||
| https://github.com/eyre-rs/eyre/pull/29/commits/608a16aa2c2c27eca6c88001cc94c6973c18f1d5 |
There was a problem hiding this comment.
👍 seems good - if it's not too much work it would be nice to record what needs to be changed upstream to add support back
There was a problem hiding this comment.
I'll ask jane what exactly broke it next time we talk, but I figure it might have shifted over the last three years =]
There was a problem hiding this comment.
I honestly don't recall, I think it was mostly error in core or the lack there of, and the horrible hacks that we had to work around that.
yaahc
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no_std support was removed in 2020 with PR #29. This change updates the documentation to reflect that as suggested in PR #89. It still mentions no_std, which will hopefully keep it on our minds enough to check sometimes and see if the upstream problem has been resolved.