Extend Option with ok_or_eyre
#129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoniePhiline
force-pushed
the
feat/option-ext
branch
4 times, most recently
from
b88e132
to
5e73f0f
Compare
ten3roberts
approved these changes
Dec 6, 2023
LeoniePhiline
commented
Dec 6, 2023
LeoniePhiline
force-pushed
the
feat/option-ext
branch
2 times, most recently
from
49d4d96
to
f1c5ab7
Compare
Previously, a closure and macro invocation was required to generate a static string error object from an `Option::None`. This change adds an extension trait, providing the `ok_or_eyre` method on the `Option` type. `Option::ok_or_eyre` accepts static error messages and creates `Report` objects lazily in the `None` case. Implements eyre-rs#125
LeoniePhiline
force-pushed
the
feat/option-ext
branch
from
f1c5ab7
to
0d81d4e
Compare
|
I will merge this now as it looks splendid. If you find a better way to make it discoverable; feel free to open up another PR 😊 |
This was referenced Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a closure and macro invocation was
required to generate a static string error object
from an
Option::None.This change adds an extension trait, providing
the
ok_or_eyremethod on theOptiontype.Option::ok_or_eyreaccepts static error messagesand creates
Reportobjects lazily in theNonecase.Implements #125