Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.6.10 #132

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Release 0.6.10 #132

merged 1 commit into from
Dec 8, 2023

Conversation

thenorili
Copy link
Contributor

Updates changelog and version references for release 0.6.10

Updates changelog and version references for release 0.6.10
@thenorili thenorili force-pushed the release branch 2 times, most recently from 1aea7fb to d4bf88f Compare December 8, 2023 06:29
@yaahc yaahc merged commit d5cad7c into eyre-rs:master Dec 8, 2023
58 checks passed
@thenorili thenorili deleted the release branch December 9, 2023 08:22
@qwandor
Copy link

qwandor commented Dec 13, 2023

It looks like this was just yanked with no compatible version available, which causes some builds to fail. What's going on? Will there be a 0.6.11 shortly?

@yaahc
Copy link
Collaborator

yaahc commented Dec 13, 2023

the last version accidentally introduced a breakage: #95

Tho I'm honestly surprised that yanking that version causes builds to fail. I would have expected it to fall back to 0.6.9, can you link to an example of a broken build so I can understand how yanking it still causes issues? We hadn't realized there was an urgency to get the rerelease back out.

@dtolnay
Copy link
Contributor

dtolnay commented Dec 13, 2023

Everything that declares a dependency on eyre 0.6.10 will fail. There are 68 results on GitHub: https://github.com/search?q=%2Feyre+%3D+%220.6.10%22%2F&type=code. It will not fall back to 0.6.9.

Unfortunately this is widespread as projects use bots to bump the dependency numbers immediately after releases are made available, even if the projects would otherwise build perfectly fine against the older version. I have not seen any of those bots monitor and correct for yanked crates.

@dtolnay
Copy link
Contributor

dtolnay commented Dec 13, 2023

Example failure: https://github.com/evenfurther/aoc/actions/runs/7189388139/job/19580870459

error: failed to select a version for the requirement `eyre = "^0.6.10"`
candidate versions found which didn't match: 0.6.9, 0.6.8, 0.6.7, ...
location searched: crates.io index
required by package `aoc v0.1.0 (/home/runner/work/aoc/aoc/aoc)`
if you are looking for the prerelease package it needs to be specified explicitly
    eyre = { version = "0.6.1-rc.1" }
perhaps a crate was updated and forgotten to be re-vendored?

@yaahc
Copy link
Collaborator

yaahc commented Dec 13, 2023

Unfortunately this is widespread as projects use bots to bump the dependency numbers immediately after releases are made available, even if the projects would otherwise build perfectly fine against the older version. I have not seen any of those bots monitor and correct for yanked crates.

unfortunate indeed, and good to know, thank you. I'll go ahead and expedite getting that re-release out asap.

@yaahc yaahc mentioned this pull request Dec 13, 2023
@yaahc
Copy link
Collaborator

yaahc commented Dec 13, 2023

should be good now: https://crates.io/crates/eyre/versions

thenorili pushed a commit that referenced this pull request Dec 30, 2023
rereleasing #132 minus one breaking
change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants