Fix invalid drop impl call in Report::downcast
#143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The context chain downcast called converted to the wrong inner type which caused the wrong drop impl to be called. The tests did not catch this because they had compatible drop implementations due to matching type layout. Solved by swizzling the fields of the chain test types to force incompatible layouts
ten3roberts
added
C-bug
dtolnay
approved these changes
Dec 29, 2023
There was a problem hiding this comment.
This seems worth publishing an advisory for: https://github.com/rustsec/advisory-db
|
Great catch, and clever work on the test! |
thenorili
approved these changes
Dec 30, 2023
|
Any reason why this fix hasn't been released yet (and affected versions yanked)? It's a known soundness issue in a popular crate. |
|
Thanks for pointing that out. There were some cross wires and folks thought it had made it into the last release when it had not. Working on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The context chain downcast called converted to the wrong inner type which caused the wrong drop impl to be called.
The tests did not catch this because they had compatible drop implementations due to matching type layout. Solved by swizzling the fields of the chain test types to force incompatible layouts
Resolves: #141