Fix overly strict clippy lint #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pksunkara
reviewed
May 16, 2024
| @@ -135,8 +135,7 @@ jobs: | |||
| - uses: actions-rs/cargo@v1 | |||
| with: | |||
| command: clippy | |||
| args: --all-targets --all-features -- -D warnings | |||
|
|
|||
| args: --all-targets --all-features -- -D clippy::style -D clippy::suspiscious -D clippy::complexity | |||
There was a problem hiding this comment.
Instead of doing it like this, it might be worth changing the stable to an MSRV.
There was a problem hiding this comment.
That makes sense, pinning the clippy version
Only danger with that is that we may not update it for a while and not get new "good to deny by default" lints.
This primarily solves the overly pedantic lints, while still giving us all the new ones as warnings.
Both are good
Maybe a combination?
Sticking to latest also makes it easier to run clippy locally, as you don't have to track which version, especially for new contributors who aren't aware of it, not understanding why there are different results.
But that is just a minor thing.
pksunkara
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deny style, suspicious and complexity categories, rather than all warnings
If we find issues that could have been caught by a clippy lint we can add that lint on as deny too, as for now, they still appear as warnings but won't prevent CI from running.
This most notably fixes random CI breakages when clippy/rust updates and introduces new warn level lints