Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make __init__.py use a relative import #42

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Conversation

bpteague
Copy link
Contributor

Instead of making cytoflow depend on fcsparser, I would like to include fcsparser as a submodule. This way, if I have fixes that I want to roll out with a cytoflow release, I don't have to wait on you to roll a new release of fcsparser. (Making new releases is harder than it should be.)

This would be a lot easier on my end if fcsparser.__init__ used a relative import instead of an absolute import. This way, the directory containing api.py doesn't have to be in sys.path. It should not effect folks who use fcsparser directly.

@eyurtsev eyurtsev merged commit a146397 into eyurtsev:master Jan 13, 2022
@eyurtsev
Copy link
Owner

Thanks! I think it's generally advisable to use relative imports in python packages that are to be distributed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants