Tests for JOIN needs fixing #200
Labels
error-bug
Issues causing application termination.
warning-bug
Issues not causing scripts/routines to die/fail.
Comments
TheTechsTech
added
warning-bug
dpDesignz
added a commit
to dpDesignz/ezsql
that referenced
this issue
Feb 5, 2021
Resolves ezSQL#200 and also fixed phpunit error `expectExceptionMessageRegExp() is deprecated in PHPUnit 8 and will be removed in PHPUnit 9. Use expectExceptionMessageMatches() instead.`
Merged
TheTechsTech
added a commit
that referenced
this issue
Feb 8, 2021
…red in doing so - bug fixes, prior to PHP 8, `**@**` silenced errors which this library used to return `**false**` instead, that is not no longer possible with PHP 8 - Linux and Windows CI tests move to GitHub Actions - General code style fixes - merged bug fix #199 - fixed tests in issue #200, and corrections for PR #201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@dpDesignz I been working on getting library updated for PHP 8, and discovered some errors show only up under it.
The tests for the Joins has issues that exists regardless of the PHP version.
In:
ezsql/tests/pdo/pdo_mysqlTest.php
Line 288 in 863c184
ezsql/tests/pdo/pdo_pgsqlTest.php
Line 210 in 863c184
ezsql/tests/pdo/pdo_sqliteTest.php
Line 239 in 863c184
ezsql/tests/pdo/pdo_sqlsrvTest.php
Line 214 in 863c184
The second tables created is not receiving any inserted data, it's going to first table only still, and should have failed, no test for real insertion check.
The text was updated successfully, but these errors were encountered: