Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use a medium format (json/yaml/toml) to store icons information for different extension/filename/pattern #440

Closed
Freed-Wu opened this issue Sep 29, 2023 · 1 comment
Assignees
Labels
rust Pull requests that update Rust code

Comments

@Freed-Wu
Copy link

Comes from ogham/exa#1138:

It is easier to edit even for those contributors is not familiar with rust https://github.com/eza-community/eza/blob/afe832b943d328a20f43c6fa69dd8588cf3285ef/src/output/icons.rs
It is easier to compare the difference between this project's icon and other projects which provide icon display, so we can add icons more easily. Such as https://github.com/lambdalisue/nerdfont.vim/blob/master/assets/json/extension.json
It is easier to sort json by some programs like jq in CI/CD

Just my 2c, TIA!

@MartinFillon
Copy link
Contributor

This needs to be discussed

@eza-community eza-community locked and limited conversation to collaborators Oct 2, 2023
@cafkafk cafkafk converted this issue into discussion #457 Oct 2, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
rust Pull requests that update Rust code
Projects
None yet
Development

No branches or pull requests

2 participants