Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use json to store icons information for different extension/filename/pattern #1138

Closed
Freed-Wu opened this issue Oct 21, 2022 · 4 comments
Closed

Use json to store icons information for different extension/filename/pattern #1138

Freed-Wu opened this issue Oct 21, 2022 · 4 comments

Comments

@Freed-Wu
Copy link
Contributor

Freed-Wu commented Oct 21, 2022 •
edited

  1. It is easier to edit even for those contributors is not familiar with rust
  2. It is easier to compare the difference between this project's icon and other projects which provide icon display, so we can add icons more easily.
  3. It is easier to sort json by jq

Just my 2c, TIA!
@Freed-Wu
Copy link
Contributor Author

Just like https://github.com/lambdalisue/nerdfont.vim/blob/master/assets/json/extension.json

@jnordwick
Copy link

why json and not line delimited?

@Freed-Wu
Copy link
Contributor Author

why json and not line delimited?

It is also OK. I just think perhaps parse json is easier (with library).

@Freed-Wu Freed-Wu mentioned this issue Sep 29, 2023
Closed
@Freed-Wu
Copy link
Contributor Author

eza-community/eza#440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jnordwick @Freed-Wu