Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --no-|show-symlinks flags for filtering output #1028

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

PThorpe92
Copy link
Member

Currently you can use --only-dirs and get only directory output, or you can use --only-files and get only files.

Someone requested the ability to hide symlinks (for some MacOS feature where they use symlinks to make their directory structure more unix-like), but I think it makes more sense to also be able to filter and get all directories or all files (symlinks or otherwise), as well as hide symlinks in normal output.

@MartinFillon
Copy link
Contributor

Hey thats kinda a duplicate of #518

@PThorpe92
Copy link
Member Author

Ah I didn't notice that previously.

We need to decide whether only-links is a flag people would use, and if it's worth the breaking changes introduced there. This PR allows for links to be shown when using --only-dirs or --only-files (when the link points to a dir or file, respectively), which seems to be what the original issue was about.

@MartinFillon
Copy link
Contributor

Yes clearly. I think that for the moment only-links might not be necessary, it was just an idea i had as we were talking about this bug in issues

@PThorpe92
Copy link
Member Author

@cafkafk this is ready 👍

Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, works perfectly 👍

(this could do with some tests as well, I've made an issue to track this #1033)

@cafkafk cafkafk merged commit 99b2fc2 into eza-community:main Jun 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants