Tree-wide: Fix Windows build #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
|
Looks like this failed on MacOS https://github.com/eza-community/eza/actions/runs/5991795977/job/16263711309?pr=171 I added windows to the CI, so when windows support is working and this merges, it will keep working (hopefully). |
|
Thanks @cafkafk, I pushed a couple of fixes but without a Mac I'm shooting in the dark. Can you give the CI another run (probably just the macos one, if that works then the rest can run as well)? |
This was referenced Aug 28, 2023
Signed-off-by: Steven Davies <github@steev.me.uk>
cafkafk
approved these changes
Sep 3, 2023
|
Windows build looks fine to me. Perhaps @cfxegbert could test this branch on Mac? |
|
I guess we'll just test this live, I feel like it's reasonable to expect it's also working on mac, if not people will probably be quick to open an issue about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have a Mac to test on, I'd appreciate it if someone could check that build out too. This branch currently builds on both Windows and Linux.
Fixes #169
Fixes #102