feat: support the MSRV of Rust (1.65.0) #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
cafkafk
approved these changes
Sep 10, 2023
Those last two CI runners failed to start yesterday as well, not sure why. |
I made an issue for it, seems odd. |
sevz17
added a commit
to sevz17/gentoo
that referenced
this pull request
Sep 13, 2023
it was lowered in eza-community/eza#236 (merged before 0.11.1) Signed-off-by: Leonardo Hernández Hernández <leohdz172@proton.me>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Sep 13, 2023
it was lowered in eza-community/eza#236 (merged before 0.11.1) Signed-off-by: Leonardo Hernández Hernández <leohdz172@proton.me> Closes: #32747 Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
cargo-msrvversions of the Rust toolchain back to 1.65.0 are confirmed as compiling on both Linux and Windows. The MSRV should only be increased once something requires it otherwise systems stuck to older compiler versions are unable to build the application. In this case, only 1.69.0 is stable in Gentoo - for an ebuild we require the declared MSRV ofezato be less than or equal to that.