Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force python-gitlab to retrieve all objects instead of the first 20 #119

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

flolauck
Copy link
Contributor

@flolauck flolauck commented Nov 7, 2023

python-gitlab limits the number of retrieved entities (groups/subgroups) to 20, see:
https://python-gitlab.readthedocs.io/en/v4.1.1/api-usage.html#pagination
This change forces python-gitlab to retrieve all entities.

This resolves #117

python-gitlab limits the number of retrieved entities (groups/subgroups)
to 20, see:
https://python-gitlab.readthedocs.io/en/v4.1.1/api-usage.html#pagination
This change forces python-gitlab to retrieve all entities.
@JonasSchubert
Copy link

@ezbz It would be great if this could be merged. Your tool is great, but doesn't work with latest Python and gitlab package.

@ezbz
Copy link
Owner

ezbz commented Dec 4, 2023

@JonasSchubert thanks for your note, currently the project is broken because I let too many unsolicited contributions break it, actively looking for contributors to help maintain the project. Will try to stabilize tests/build and look into it soon

@chrisdlangton
Copy link

chrisdlangton commented Dec 10, 2023

Honestly this PR would make the broken repo actually usable again at least - you might consider making a release with at least this PR before refactor or concerns about test quality that are good for nerd brags - but this PR actually gets the project useful once again and should be more important than those kind of nice to haves.

@pujariranganath
Copy link

Any update on this?

@ezbz ezbz merged commit a9586a1 into ezbz:master Jun 30, 2024
ezbz added a commit that referenced this pull request Jun 30, 2024
…ral approved PRs that broke them

- remove incompatible root group PR: #89
- integrate useful conflicting PR by @gsobczyk for excluding shared projects
- added support for incorrect PR (#119) by adding the get_all parameter to projects (the PR has it on groups and subgroups but it doesn't work since this parameter doesn't exist on these methods https://github.com/ezbz/gitlabber/pull/119/files) so the original PR cannot be merged without breaking the project
ezbz added a commit that referenced this pull request Jun 30, 2024
@ezbz
Copy link
Owner

ezbz commented Jun 30, 2024

This PR is broken I added another to fix it

@ezbz ezbz mentioned this pull request Jun 30, 2024
ezbz added a commit that referenced this pull request Jun 30, 2024
* update library dependencies

* - recover passing state for unit / integration / e2e tests after several approved PRs that broke them
- remove incompatible root group PR: #89
- integrate useful conflicting PR by @gsobczyk for excluding shared projects
- added support for incorrect PR (#119) by adding the get_all parameter to projects (the PR has it on groups and subgroups but it doesn't work since this parameter doesn't exist on these methods https://github.com/ezbz/gitlabber/pull/119/files) so the original PR cannot be merged without breaking the project

* add actually working support for attempted PR: #119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants