Feature/check quick hover bug #5
Conversation
|
Coverage remained the same at 100.0% when pulling e07472dfd08020f9277bc1c0581d81edf4fa13ae on feature/check-quick-hover-bug into fca1454 on master. |
| @@ -49,10 +49,13 @@ | |||
| "chai-spies": "^0.7.1", | |||
| "coveralls": "^2.11.15", | |||
| "enzyme": "^2.6.0", | |||
| "eslint": "^3.10.2", | |||
| "eslint": "3.10.2", | |||
| "eslint-config-airbnb": "13.0.0", | |||
| "eslint-config-standard": "^6.2.1", | |||
There was a problem hiding this comment.
Do we need this dependency? Maybe make clean up?
There was a problem hiding this comment.
Yes, removed this dependency.
|
Coverage remained the same at 100.0% when pulling ccd96e5b20c160f9abfeab40097cb3987ca54a47 on feature/check-quick-hover-bug into fca1454 on master. |
|
@Eugen1992 please check package.json dependecies. |
|
Coverage remained the same at 100.0% when pulling bd1a220523fd869cc1430aa06acd00fe39147702 on feature/check-quick-hover-bug into fca1454 on master. |
| "eslint-config-standard": "^6.2.1", | ||
| "eslint-config-airbnb": "13.0.0", | ||
| "eslint-plugin-import": "2.2.0", | ||
| "eslint-plugin-jsx-a11y": "2.2.3", | ||
| "eslint-plugin-promise": "^3.4.0", | ||
| "eslint-plugin-react": "^6.4.1", | ||
| "eslint-plugin-standard": "^2.0.1", |
There was a problem hiding this comment.
Why we need this dependency?
There was a problem hiding this comment.
In order to run tests with airbnb config
There was a problem hiding this comment.
I commented eslint-plugin-standard which not used by airbnb
There was a problem hiding this comment.
Tests fail without this dependency as well. I guess airbnb config relies on this one. I might check for more details.
| mouseOutHandler(currentTarget); | ||
| } | ||
| renderInnerList() { | ||
| let result; |
There was a problem hiding this comment.
do we can use return without making this unused variable?
There was a problem hiding this comment.
We can. But default eslint settings do not allow it and I personally find it more readable.
EugeneAlforov
force-pushed
the
feature/check-quick-hover-bug
branch
from
bd1a220
to
dabee14
Compare
|
Cleaned commit history. |
|
Coverage remained the same at 100.0% when pulling dabee14de8173368bbb8b1a0063f75c2704b2663 on feature/check-quick-hover-bug into fca1454 on master. |
|
Coverage remained the same at 100.0% when pulling 434aadf85562c05487aaeb69e1d3e17370dacfa3 on feature/check-quick-hover-bug into fca1454 on master. |
EugeneAlforov
force-pushed
the
feature/check-quick-hover-bug
branch
from
434aadf
to
d118f06
Compare
|
Coverage remained the same at 100.0% when pulling d118f06e1f1f57e732929fa099e74b3fb4145b43 on feature/check-quick-hover-bug into fca1454 on master. |
EugeneAlforov
force-pushed
the
feature/check-quick-hover-bug
branch
from
d118f06
to
7258e93
Compare
|
Coverage remained the same at 100.0% when pulling 7258e93423b35ddb6e5a542bf98960e017f29046 on feature/check-quick-hover-bug into fca1454 on master. |
EugeneAlforov
force-pushed
the
feature/check-quick-hover-bug
branch
from
7258e93
to
1a29686
Compare
|
Coverage remained the same at 100.0% when pulling 1a29686259d6996ad0c31a6b44def39bf5648b99 on feature/check-quick-hover-bug into fca1454 on master. |
EugeneAlforov
force-pushed
the
feature/check-quick-hover-bug
branch
from
1a29686
to
dbf075f
Compare
Rebased. Had delete branch on remote.
Build has passed ok.