Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage empty lines #36

Closed
ezhlobo opened this issue Aug 23, 2018 · 1 comment
Closed

Manage empty lines #36

ezhlobo opened this issue Aug 23, 2018 · 1 comment
Labels
rule request

Comments

@ezhlobo
Copy link
Owner

ezhlobo commented Aug 23, 2018

There are some patterns which we can ask to follow:

  • Empty line in the beginning

    // Bad
pug`div`

// Good
pug`
  div`

  • Empty line in the end

    // Bad
pug`div`

// Good
pug`div
`

  • No more than 1 empty line

    // Bad
pug`
  div


  div
`

  • Add empty line when we go out from nesting

    // Bad
pug`
  div
    div
  div
`

// Good
pug`
  div
    div

  div
`

  • Add empty line in case we write more than two siblings

    // Bad
pug`
  div
  div
  div
`

// Good
pug`
  div
  div
`

pug`
  div

  div

  div
`
@ezhlobo ezhlobo mentioned this issue Aug 29, 2018
Merged
ezhlobo added a commit that referenced this issue Aug 29, 2018
@ezhlobo
Add rule "empty-lines" to enforce consisten empty lines (#40)
3640621 
* Require empty line in the beginning
* Require empty line in the end
* Require empty line before we go out from nesting
* Require empty line between siblings (if there are more than 2 siblings)
* Prohibit more than 1 empty line

Request: #36
@ezhlobo
Copy link
Owner Author

ezhlobo commented Aug 29, 2018

Done with v0.5.0

@ezhlobo ezhlobo closed this as completed Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rule request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ezhlobo