Check the usage of prop-types in pug templates #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lint-plugin-react)
…mong with FunctionDeclaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we are adding the supporting of prop-types used inside pug. That means we can check whether we define redundant props or we use something not verified by prop-types definitions.
The initial issue with statuses: #66
I've been testing this rule for two month on three active projects, caught and fixed everything according to our code style. Unfortunately, as we don't use classes, we don't have that supporting here. We can add it but I need to find out an extra time so it can take some time.
I'm creating a PR now but it still requires some additional improvements: