Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webdav_cert_path and webdav_cert_key ignored? #43

Closed
danielloader opened this issue Feb 14, 2020 · 1 comment
Closed

webdav_cert_path and webdav_cert_key ignored? #43

danielloader opened this issue Feb 14, 2020 · 1 comment

Comments

@danielloader
Copy link
Contributor

Are these two attributes ignored? They don't seem to be in the code base in any functional way unless I've missed something obvious.
ajordanBBN added a commit to ajordanBBN/webdav-client-python-3 that referenced this issue Apr 6, 2020
@ajordanBBN
Fixes ezhov-evgeny#43 - local certificate options ignored
02f2cc2 
If the webdav_cert_path and webdav_key_path options are set, they
should be passed to the call to requests in Client.execute_request
as the cert parameter.
@ajordanBBN
Copy link
Contributor

I was having the same problem. I think it's a one-line fix to add a cert=(...) argument to the call to requests in execute_request. At least, this fixes it in my test environment. I opened a pull request to apply that fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielloader @ajordanBBN