Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop roll() from failing if the new cache folder is not created #243

Merged
merged 3 commits into from
Sep 25, 2020
Merged

stop roll() from failing if the new cache folder is not created #243

merged 3 commits into from
Sep 25, 2020

Commits on Sep 25, 2020

  1. stop roll() from failing if the new cache has no files 

    Today I stumbled upon an error where it would fail when the cache folder was not present
```(typescript) Error: ENOENT: no such file or directory, rename 'REDACTED\node_modules\.cache\rollup-plugin-typescript2/rpt2_759e2fd8d3f20c1a0805faf5404af6bea36632fd/code/cache_' -> 'REDACTED\node_modules\.cache\rollup-plugin-typescript2/rpt2_759e2fd8d3f20c1a0805faf5404af6bea36632fd/code/cache'```

This PR fixes it by checking its existence before trying to rename it
    @xaviergonz
    xaviergonz committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    f4015c1 View commit details
    Browse the repository at this point in the history

  2. use existsSync instead of fs.existsSync

    @xaviergonz
    xaviergonz committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    e1de17e View commit details
    Browse the repository at this point in the history

  3. use renameSync instead of fs.renameSync

    @xaviergonz
    xaviergonz committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    fe9aed6 View commit details
    Browse the repository at this point in the history