Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cache): makeName -> createHash for clarity #355

Merged
merged 2 commits into from
Jun 14, 2022
Merged

refactor(cache): makeName -> createHash for clarity #355

merged 2 commits into from
Jun 14, 2022

Commits on Jun 11, 2022

  1. refactor(cache): makeName -> createHash for clarity 

    - I've actually been confused multiple times as to what `makeName` does when I read through the cache
  - I re-read the code and then am like "oh it's the hash"...
  - so thought renaming it to `createHash` would make things **a lot** clearer
    - `Name` -> `Hash`
    - `make` -> `create` because that's the more common terminology in programming

- also rename variables that reference `makeName`'s return from `name` to `hash`
  - for the same reason around clarity -- this way it's quicker to interpret whenever you see it too
  - not to mention, `name` can be confusing since we also have `id`, which is a path that is very similar to a name too
    - and lots of `fileName`s too
    - so good to disambiguate/differentiate a bit
    @agilgur5
    agilgur5 committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    a88319a View commit details
    Browse the repository at this point in the history

  2. rename object-hash default import so no shadowed variables

    @agilgur5
    agilgur5 committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    ef28f9c View commit details
    Browse the repository at this point in the history