Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cache): split a getCached function out #360

Merged
merged 1 commit into from
Jun 24, 2022

Commits on Jun 17, 2022

  1. refactor(cache): split a getCached function out

    - basically, refactor the `getDiagnostics` a tiny bit to also handle what the `getCompiled` function needs
      - then just call `getCached` from both instead
      - `getDiagnostics` and `getCompiled` were near identical except for the cache they used and `checkImports`, which are both parameters now
        - `getCompiled` also had a logging statement (called in both `noCache` and w/ cache branches), which was moved to before the call to `getCompiled` instead
        - the `type` param was composed into another function in `getDiagnostics` before the call too `getCached` now
      - this simplifies all the cache code to one main function now
    
    - remove the `markAsDirty` call under `noCache`, as well, "dirty" has no meaning for `noCache` anyway
      - this simplifies that one `if` statement now too
    agilgur5 committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    26c5eac View commit details
    Browse the repository at this point in the history