Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/clean: formally deprecate rollupCommonJSResolveHack #367

Merged
merged 2 commits into from Jun 24, 2022

Commits on Jun 23, 2022

  1. docs/clean: formally deprecate rollupCommonJSResolveHack

    - this has had no effect since 6fb0e75, released in 0.30.0
      - that changed the code to always return OS native paths via the NodeJS Path API
        - so setting `rollupCommonJSResolveHack` would make no difference either `true` or `false`
          - effectively, it's as if it's always `true` now
    
    - formally state now that this is deprecated in the docs
      - as well as when that occurred and what it means
    
    - also add a warning in `options` similar to the existing one for `objectHashIgnoreUnknownHack`
    
    - remove the `resolve` dependency as well
      - it turns out something in the devDeps still uses it, so it didn't get fully removed in the `package-lock.json`
      - `resolve` was never needed anyway as we could've used NodeJS's native `path.resolve` or `require.resolve` instead
        - `resolve` was created for `browserify` after all, where one can't use NodeJS APIs
          - but we run on NodeJS and can and already do use NodeJS APIs, including both `path.resolve` _and_ `require.resolve`
      - I actually started this commit just to remove the dep, then realized the entire code path is obsolete
    agilgur5 committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    107b67f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    138965b View commit details
    Browse the repository at this point in the history