Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Moving to aiida-core BaseRestartWorkChain #6

Closed
3 tasks done
ezpzbz opened this issue Jul 22, 2020 · 1 comment
Closed
3 tasks done

[Feature] Moving to aiida-core BaseRestartWorkChain #6

ezpzbz opened this issue Jul 22, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ezpzbz
Copy link
Owner

ezpzbz commented Jul 22, 2020

Currently, we are using the BaseRestartWorkchain from aiida-vasp plugin. It is the implementation that was introduced in aiida-quantumespresso at the first place and then started to being used in every plugin. However, as it was quite useful, AiiDA team has moved it to the aiida-core and improved it by adding nice error handling mechanism. Therefore, it is a good idea that we also start using it in our workchain. It requires:

  • Carefull reading the plugin to avoid possible bugs that can be introduced and break the current API
  • Implementing it and add at least one error handler to have a starting point
  • testing it and making it ready to be merged into master.
@ezpzbz ezpzbz added the enhancement New feature or request label Jul 22, 2020
@ezpzbz ezpzbz added this to the v0.3.0 milestone Jul 22, 2020
@ezpzbz ezpzbz self-assigned this Jul 22, 2020
@ezpzbz
Copy link
Owner Author

ezpzbz commented Aug 9, 2020

These are implemented in base_restart branch. The required error handling stuffs within the workchain need to be impleneted at plugin level. The reason is that we can spot if a subprocess has failed but relating it to the error cannot be done easily at this level.
Thefore, we define the exit codes in plugin, then we have an error parser which acts at workchain level. If it spots subprocess failures, it registers the error code coming from plugin. The handler then acts based on that (again at workchain level)

@ezpzbz ezpzbz closed this as completed Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant