Fixes #30913 - drop environment field from Host(group) form #33
Conversation
ezr-ondrej
force-pushed
the
drop_host_environment_field
branch
5 times, most recently
from
9022167
to
ba20fad
Compare
ezr-ondrej
force-pushed
the
puppet_extraction
branch
from
2ed777a
to
2388198
Compare
ezr-ondrej
force-pushed
the
drop_host_environment_field
branch
2 times, most recently
from
137e02a
to
7fb939d
Compare
| @@ -296,7 +255,6 @@ function handleHostgroupChangeEdit(element, host_id, host_changed) { | |||
| } else { | |||
| // edit host | |||
| set_inherited_value(element); | |||
| update_puppetclasses(element); | |||
There was a problem hiding this comment.
How do we handle this and other events that should reload/update one of the puppet tabs?
There was a problem hiding this comment.
I've moved all these functions to the webpack file in plugin and added the events to the global js file:
https://github.com/theforeman/foreman_puppet_enc/pull/64/files#diff-c26a70779db93ece76946fdfe9f914a20986c4177863883f79a75dab2d7bd90eR14-R30
I've tried hard to decode when should the tabs/info get reloaded and do the same.
One difference that I didn't know how to avoid is reloading the puppet parameters on OS and domain change. Now we are changing it after the ajax (os_changed, domain_change) success, but in the plugin I'm running them right away after the selection. Hopefully it should not be an issue and I've tested it's ok, but I'm not sure if I've missed something that could get affected by that 🤔
ezr-ondrej
force-pushed
the
puppet_extraction
branch
from
2b88e52
to
a49a9e1
Compare
Drops the environment field and all js attached to it. Extracted in theforeman/foreman_puppet#64.
ezr-ondrej
force-pushed
the
drop_host_environment_field
branch
from
7fb939d
to
b325925
Compare
|
Lets get this over with. |
Drops the environment field and all js attached to it.
Extracted in theforeman/foreman_puppet#64.