Repository update fails already if only one repository is offline

[tobias-klein]

There are eight repositories in CrossWire's master repository list. If any of them fail to update the complete update fails. The behavior should be changed:

• Succeed if two or less repositories fail to update
• Fail if at least two repositories fail to update

[zhuiks]

This give us some trouble running automated acceptance tests!

@tobias-klein from Node-Sword-Interface side can you provide more details as a result from updateRepositoryConfig()?

We can make decision then in front-end, based on the repository's online statuses

[tobias-klein]

Yes, you're right @zhuiks
I was already thinking about this one when seeing the GitHub actions issues this week.

And yes, we could return a more detailed status from updateRepositoryConfig. It could be an Object with a status attribute for each repository that is queried.

[tobias-klein]

@zhuiks
I have just published node-sword-interface 0.238.0 (not integrated here yet - feel free to take that up).

In the new version of node-sword-interface the function updateRepositoryConfig returns a Promise, which in turn returns an object like this:

{
  'result': false,
  'Bible.org': false,
  'CrossWire': true,
  'CrossWire Attic': true,
  'CrossWire Beta': true,
  'CrossWire Wycliffe': true,
  'Deutsche Bibelgesellschaft': true,
  'IBT': true,
  'Lockman Foundation': true,
  'Xiphos': true,
  'eBible.org': true
} 

The status value is simply a boolean. true means successful and false that the update failed for that particular repo. In the example above you see that the Bible.org repo is currently failing to update correctly. Note that with this change the Promise returned by updateRepositoryConfig always resolves (never rejects) and delivers that status object. Previously that Promise rejected in case of an overall unsuccessful repo update.

Note that integration of this node-sword-interface change requires touching both the backend (ipc_nsi_handler.js) as well as the frontend (ipc_nsi.js) and then of course handling it correspondingly in the UI.