Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag groups #641

Merged
merged 174 commits into from
Apr 15, 2022
Merged

Tag groups #641

merged 174 commits into from
Apr 15, 2022

Conversation

tobias-klein
Copy link
Member

@tobias-klein tobias-klein commented Mar 5, 2022

See discussion #540.

@tobias-klein tobias-klein added this to Implementing in 1.6 / April 23 2022 via automation Mar 8, 2022
@tobias-klein
Copy link
Member Author

@debritto
Would you like to provide early user feedback?
Current builds are available here.

Note that I haven't considered the tag groups in the Bible browser or export functions yet. What you can provide feedback on is the UI in the tag list, which now allows to browse tags based on tag groups and perform all necessary edit operations on tag groups.

@debritto
Copy link
Collaborator

Hi @tobias-klein !
Sure. I'll install the new dev version right now.

@tobias-klein
Copy link
Member Author

@debritto
The latest build has a few bugfixes related to the tag group management and also features a new option to filter the tags shown in the Bible text - based on the currently selected tag group (see new option in options menu).

…roller / Validate tag changes including tag groups
@tobias-klein tobias-klein moved this from Implementing to Testing in 1.6 / April 23 2022 Apr 8, 2022
@tobias-klein tobias-klein marked this pull request as ready for review April 10, 2022 07:03
@tobias-klein
Copy link
Member Author

tobias-klein commented Apr 10, 2022

@zhuiks
This is a fairly big PR, but it only makes sense in one piece :)
Would you like to look over it? Any feedback before I merge?

@debritto @augustin-colesnic
Any testing feedback on this PR before I merge?
The latest build is here.

@zhuiks
Copy link
Collaborator

zhuiks commented Apr 11, 2022

@zhuiks This is a fairly big PR, but it only makes sense in one piece :) Would you like to look over it? Any feedback before I merge?

Sorry, I don't think I'll have time for at least couple more month.

@tobias-klein
Copy link
Member Author

Ok! Thanks for the feedback!

@tobias-klein tobias-klein merged commit 28a7c59 into master Apr 15, 2022
1.6 / April 23 2022 automation moved this from Testing to Done Apr 15, 2022
@tobias-klein tobias-klein deleted the feature-tag-groups branch April 15, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
4 participants