Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch object-alloc and dependents to NonNull raw pointers #140

Closed
joshlf opened this issue Dec 22, 2017 · 0 comments
Closed

Switch object-alloc and dependents to NonNull raw pointers #140

joshlf opened this issue Dec 22, 2017 · 0 comments
Labels
component-mmap-alloc component-object-alloc component-object-alloc-test component-slab-alloc experience-medium help wanted

Comments

@joshlf
Copy link
Collaborator

joshlf commented Dec 22, 2017 •
edited
Loading

Now that rust-lang/rust#46952 has landed, we should switch to using NonNull pointers where appropriate. This will help with both performance and correctness. This issue focuses only on object-alloc's traits and the crates that depend on it. #147 focuses on other uses.
@joshlf joshlf changed the title Switch to NonNull raw pointers Switch object-alloc and dependents to NonNull raw pointers Feb 16, 2018
@joshlf joshlf mentioned this issue Feb 16, 2018
Open
joshlf added a commit that referenced this issue Feb 16, 2018
@joshlf
object-alloc: Switch from *mut to NonNull
f7f1f08 
- Switch from *mut u8 and *mut T to NonNull<u8> and NonNull<T>
  in trait methods
- Upgrade slab-alloc, mmap-alloc, and object-alloc-test accordingly
- Closes #140
@joshlf joshlf mentioned this issue Feb 16, 2018
Merged
joshlf added a commit that referenced this issue Feb 16, 2018
@joshlf
object-alloc: Switch from *mut to NonNull
e10d0b2 
- Switch from *mut u8 and *mut T to NonNull<u8> and NonNull<T>
  in trait methods
- Upgrade slab-alloc, mmap-alloc, and object-alloc-test accordingly
- While upgrading slab-alloc to use the latest mmap-alloc, remove
  support for huge pages (since mmap-alloc no longer supports them)
- Closes #140
joshlf added a commit that referenced this issue Feb 16, 2018
@joshlf
object-alloc: Switch from *mut to NonNull
b4c4ccf 
- Switch from *mut u8 and *mut T to NonNull<u8> and NonNull<T>
  in trait methods
- Upgrade slab-alloc, mmap-alloc, and object-alloc-test accordingly
- While upgrading slab-alloc to use the latest mmap-alloc, remove
  support for huge pages (since mmap-alloc no longer supports them)
- Closes #140
joshlf added a commit that referenced this issue Feb 16, 2018
@joshlf
object-alloc: Switch from *mut to NonNull
b252f6c 
- Switch from *mut u8 and *mut T to NonNull<u8> and NonNull<T>
  in trait methods
- Upgrade slab-alloc, mmap-alloc, and object-alloc-test accordingly
- While upgrading slab-alloc to use the latest mmap-alloc, remove
  support for huge pages (since mmap-alloc no longer supports them)
- Closes #140
joshlf added a commit that referenced this issue Feb 16, 2018
@joshlf
object-alloc: Switch from *mut to NonNull
94ce251 
- Switch from *mut u8 and *mut T to NonNull<u8> and NonNull<T>
  in trait methods
- Upgrade slab-alloc, mmap-alloc, and object-alloc-test accordingly
- While upgrading slab-alloc to use the latest mmap-alloc, remove
  support for huge pages (since mmap-alloc no longer supports them)
- Closes #140
joshlf added a commit that referenced this issue Feb 19, 2018
@joshlf
object-alloc: Switch from *mut to NonNull
1d8f84c 
- Switch from *mut u8 and *mut T to NonNull<u8> and NonNull<T>
  in trait methods
- Upgrade slab-alloc, mmap-alloc, and object-alloc-test accordingly
- While upgrading slab-alloc to use the latest mmap-alloc, remove
  support for huge pages (since mmap-alloc no longer supports them)
- Closes #140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component-mmap-alloc component-object-alloc component-object-alloc-test component-slab-alloc experience-medium help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshlf