Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alloc-tls: custom thread-local variable implementation #85

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Add alloc-tls: custom thread-local variable implementation #85

merged 1 commit into from
Nov 16, 2017

Conversation

joshlf
Copy link
Collaborator

@joshlf joshlf commented Sep 21, 2017

No description provided.

@joshlf joshlf changed the title [WIP] elfmalloc: Custom thread-local variable implementation [WIP] Add alloc-tls: custom thread-local variable implementation Oct 8, 2017
This was referenced Oct 13, 2017
Open
Merged
@joshlf joshlf changed the title [WIP] Add alloc-tls: custom thread-local variable implementation Add alloc-tls: custom thread-local variable implementation Oct 20, 2017
@joshlf joshlf mentioned this pull request Oct 24, 2017
Closed
@joshlf
alloc-tls: Initial commit
522ae8d 
- Add alloc-tls crate
  - Supports detecting recursive initialization
  - Supports disabling TLS during dynamic load on Mac
- elfc: Support alloc-tls hooks for dynamic loading on Mac
- elfc: Don't run 'cargo test' in CI
- elfmalloc: Switch to using alloc-tls
- elfmalloc: Remove nightly feature
@joshlf
Copy link
Collaborator Author

joshlf commented Nov 16, 2017

@ezrosent and I have verified that this change does not adversely affect performance. Unfortunately, getting to that state required the addition of the somewhat-unergonomic macro alloc_tls_fast_with - calling the with method directly significantly degraded performance. This probably reflects a missed optimization opportunity that could be reported to the rustc folks.

@joshlf joshlf merged commit e753208 into master Nov 16, 2017
@joshlf joshlf deleted the tls branch November 16, 2017 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezrosent ezrosent ezrosent approved these changes

Assignees
No one assigned
Labels
component-elfmalloc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshlf @ezrosent