Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with php 8.0 #215

Closed
johnny-apple opened this issue Apr 24, 2022 · 1 comment
Closed

Not compatible with php 8.0 #215

johnny-apple opened this issue Apr 24, 2022 · 1 comment
Labels
error-bug Issues causing application termination. warning-bug Issues not causing scripts/routines to die/fail.

Comments

@johnny-apple
Copy link

Describe the bug
upon upgrade to php 8.0, you will get several deprecated function errors and warnings:
Deprecated: Required parameter $fromTable follows optional parameter $totable in vendor/ezsql/ezsql/lib/ezFunctions.php on line 324
Deprecated: Required parameter $keyValue follows optional parameter $table in vendor/ezsql/ezsql/lib/ezFunctions.php on line 439
Deprecated: Required parameter $keyValue follows optional parameter $table in vendor/ezsql/ezsql/lib/ezFunctions.php on line 446
Deprecated: Required parameter $keyValue follows optional parameter $table in vendor/ezsql/ezsql/lib/ezFunctions.php on line 460
Warning: The magic method ezsql\Database::__wakeup() must have public visibility in vendor/ezsql/ezsql/lib/Database.php on line 22
Deprecated: Required parameter $keyAndValue follows optional parameter $table in vendor/ezsql/ezsql/lib/ezQuery.php on line 631
Deprecated: Method ReflectionParameter::getClass() is deprecated in vendor/ezsql/ezsql/lib/DInjector.php on line 132
Deprecated: Method ReflectionParameter::getClass() is deprecated in vendor/ezsql/ezsql/lib/DInjector.php on line 132
Deprecated: Method ReflectionParameter::getClass() is deprecated in vendor/ezsql/ezsql/lib/DInjector.php on line 132

To Reproduce
swap from php 7.4 to php 8.0 or 8.1
Expected behavior
as previous, no errors or warnings.

Warning: Failing to provide necessary information may cause the issue to be closed without consideration

Environment (please complete the following information):

  • EZSQL Version : 5.1
  • PHP Version: 8.0 or 8.1
  • SQL Driver:[ mysql, pgsql, sqlserver, sqlite3] mysql

PHP code snippet used

<?php
@johnny-apple johnny-apple added error-bug Issues causing application termination. warning-bug Issues not causing scripts/routines to die/fail. labels Apr 24, 2022
@TheTechsTech
Copy link
Contributor

You might need to update esql version to 5.1.1, There are tests running under Linux for 7.4 and 8.0 see https://github.com/ezSQL/ezsql/runs/5090738700?check_suite_focus=true the warning are for PHPunit version Tests

Compatibility has not been addressed for PHP 8.1 yet, 7.4 and 8.0 has already been addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error-bug Issues causing application termination. warning-bug Issues not causing scripts/routines to die/fail.
Projects
None yet
Development

No branches or pull requests

2 participants