Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-24566: Add "Rich Text" field to Almighty content type in demo bundle #174

Merged
merged 1 commit into from
Aug 28, 2015

Conversation

clash82
Copy link
Contributor

@clash82 clash82 commented Aug 24, 2015

@ezrobot
Copy link

ezrobot commented Aug 24, 2015

@ezrobot
Copy link

ezrobot commented Aug 25, 2015

@clash82 clash82 changed the title EZP-24566: Add "Rich Text" field to Almighty content type in demo bundle [WIP] EZP-24566: Add "Rich Text" field to Almighty content type in demo bundle Aug 26, 2015
@andrerom
Copy link
Contributor

@clash82 Difficult rebase on this one? :) ping me on when you think this can be done considering your agenda with @SylvainGuittard. Just need to know as I plan to add a tag after this is in.

@ezrobot
Copy link

ezrobot commented Aug 26, 2015

@clash82
Copy link
Contributor Author

clash82 commented Aug 26, 2015

@andrerom sorry for that. I had some problems with my eZ installation :) This task was not so easy due to ezrichtext is not supported by legacy and ContentType editing is not yet implemented in PlatformUI.

@ezrobot
Copy link

ezrobot commented Aug 26, 2015

@clash82 clash82 changed the title [WIP] EZP-24566: Add "Rich Text" field to Almighty content type in demo bundle EZP-24566: Add "Rich Text" field to Almighty content type in demo bundle Aug 27, 2015
@clash82
Copy link
Contributor Author

clash82 commented Aug 27, 2015

ping @andrerom

@@ -608,7 +609,6 @@ INSERT INTO `ezcontentclass_classgroup` VALUES (37,0,3,'Media');
INSERT INTO `ezcontentclass_classgroup` VALUES (38,0,1,'Content');
INSERT INTO `ezcontentclass_classgroup` VALUES (39,0,1,'Content');
INSERT INTO `ezcontentclass_classgroup` VALUES (40,0,1,'Content');
INSERT INTO `ezcontentclass_classgroup` VALUES (40,1,1,'Content');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not be here I think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand is that second insert value here:

INSERT INTO `ezcontentclass_classgroup` VALUES (40,1,1,'Content');

is contentclass_version and since eZ Publish decided to remove unused version (draft?) it's ok. I'm not so familiar with content structure, can someone confirm this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, this one is ok.

@ezrobot
Copy link

ezrobot commented Aug 27, 2015

@andrerom
Copy link
Contributor

+1, ping @bdunogier / @pspanja

@bdunogier
Copy link
Member

+1

andrerom added a commit that referenced this pull request Aug 28, 2015
EZP-24566: Add "Rich Text" field to Almighty content type in demo bundle
@andrerom andrerom merged commit 65b0457 into ezsystems:master Aug 28, 2015
@clash82 clash82 deleted the almighty-richtext branch August 28, 2015 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants