Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-25720: Update type hint to use the proper event class #54

Merged
merged 1 commit into from Apr 26, 2016
Merged

EZP-25720: Update type hint to use the proper event class #54

merged 1 commit into from Apr 26, 2016

Conversation

wizhippo
Copy link
Contributor

@andrerom
Copy link
Contributor

+1

@emodric
Copy link
Collaborator

emodric commented Apr 26, 2016

+1

Can we get a tag please? :)

@lolautruche
Copy link
Contributor

+1

@andrerom andrerom merged commit fb15950 into ezsystems:master Apr 26, 2016
@crevillo
Copy link
Contributor

+1

@yassinechabli
Copy link

running composer install from my ezpublish project show this error :
[ErrorException]
Declaration of eZ\Bundle\EzPublishLegacyBundle\Composer\ScriptHan
dler::installAssets() should be compatible with Sensio\Bundle\Dis
tributionBundle\Composer\ScriptHandler::installAssets(Composer\Sc
ript\Event $event)

i think the function installAssets in the classes is confusion with Event and CommandEvent arguments .
please , i need help to solve it.
i don't know what to do with the link up

@andrerom
Copy link
Contributor

@yassinechabli if you have this patch, make sure you also have corresponding SensioDis
tributionBundle version (see link in description of pull request here).

@yassinechabli
Copy link

in my composer i have "sensio/distribution-bundle": "~2.3|~3.0" , sould i upgrade it to a higher version ?

@andrerom
Copy link
Contributor

You should make sure you have one of the versions in the link above, so one of v5.0.18 v5.0.17 v5.0.16 v5.0.15 v5.0.14 v5.0.13 v5.0.12 v5.0.11 v5.0.10 v5.0.9 v5.0.8 v5.0.7 v5.0.6 v4.0.38 v4.0.37 v4.0.12 v4.0.11 v4.0.10 v4.0.9 v4.0.8 v4.0.7 v4.0.6 v3.0.36

meaning "sensio/distribution-bundle": "^3.0.36|^4.0.6|^5.0.6"

I realize this should be updated here in composer.json also: #86, but you should reflect this in your root composer.json anyway.

andrerom added a commit that referenced this pull request Mar 23, 2017
@yassinechabli
Copy link

yassinechabli commented Mar 23, 2017

i run composer install but i don't know why composer require an authentification (username and password ) for this site : http://updates.ez.no/

@andrerom
Copy link
Contributor

andrerom commented Mar 23, 2017

@yassinechabli sounds like you have eZ Publish Enterprise or eZ Platform Enterprise ("Studio") installed. See: https://doc.ez.no/display/DEVELOPER/Using+Composer

For further questions not relevant to this PR, post them on slack: https://ezcommunity.slack.com
(self sign up: https://ez-community-on-slack.herokuapp.com/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants