hasInstance method is missing in the Kernel.php

[fireflyfolio]

Hello,

We're trying to migrate our former sites developed with eZ Publish 5.x in Legacy mode to eZ Platform 6.9.x with LegacyBridge 1.2.x.

I've noticed that the following folder has been moved from eZ Publish 5.x:
vendor/ezsystems/ezpublish-kernel/eZ/Publish/Core/MVC/Legacy
to
vendor/ezsystems/legacy-bridge/mvc

And the method hasInstance() has been removed from the class Kernel.php.

Could you give us the reason? Is it because it was used for Singleton Pattern which is considered now as an anti-pattern?

And is it possible to reintegrate it again?

The issue is that method is called in the following class:
vendor/ezsystems/legacy-bridge/bundle/Collector/TemplateDebugInfo.php

And other various classes as well.

Thank you in advance for your feedback.

Regards,

Quentin

Here is the method hasInstance extracted from eZ Publish 5.x :

/**
 * Checks if LegacyKernel has already been instantiated.
 *
 * @return bool
 */
public static function hasInstance()
{
    return static::$instance !== null;
}

[lolautruche]

Hi @quentinthai
I think you need to rebase your branch 😃

[fireflyfolio]

Hi @lolautruche
No problem. I've just selected the latest stable branch and put my PR in it... ^^

[lolautruche]

I don't see your commit in the commits list

[lolautruche]

@quentinthai This method has been removed in eb717c1 but should still work since Kernel extends ezpKernel (from ezpublish-legacy) which does have this class.

Can you please show the error + stack trace you get?

[fireflyfolio]

@lolautruche, sure, here is my stack trace :

`Whoops, looks like something went wrong.

1/1
UndefinedMethodException in TemplateDebugInfo.php line 29:
Attempted to call an undefined method named "hasInstance" of class "eZ\Publish\Core\MVC\Legacy\Kernel".
in /home/users/webthai/ezplatform-poc/vendor/ezsystems/legacy-bridge/bundle/Collector/TemplateDebugInfo.php line 29`

[fireflyfolio]

@lolautruche : And I didn't commit any code. It's just a remark... Sorry, I've just realized that I should have created an issue instead... ^^

Could you explain your remark please?

but should still work since Kernel extends ezpKernel (from ezpublish-legacy) which does have this class. ?

It seems the ezpKernel class doesn't define the hasInstance method... and we use eZ Publish Legacy 2014.11 which is the minimum version required by LegacyBridge according to its composer.json

[fireflyfolio]

Moved to Issue: #94