-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hasInstance method is missing in the Kernel.php #93
Conversation
* Update PHP CS Fixer to v2 * Ran CS fixer
* Fix routerpass to use defined class * Use FQCN as string, since legacy bridge still supports PHP 5.4. * Simplify routing pass
Symfony 3.x compatibility
* Add Option to use NotFoundHttpException for 404 HTTP errors * Add Option to use NotFoundHttpException for 404 HTTP errors (Test) * Add Option to use NotFoundHttpException for 404 HTTP errors (Add an E_USER_DEPRECATED if legacy handles the 404 error)
…sponse when converting 404 (#92)
Hi @quentinthai |
Hi @lolautruche |
I don't see your commit in the commits list |
@quentinthai This method has been removed in eb717c1 but should still work since Can you please show the error + stack trace you get? |
@lolautruche, sure, here is my stack trace : `Whoops, looks like something went wrong. 1/1 |
@lolautruche : And I didn't commit any code. It's just a remark... Sorry, I've just realized that I should have created an issue instead... ^^ Could you explain your remark please?
It seems the ezpKernel class doesn't define the hasInstance method... and we use eZ Publish Legacy 2014.11 which is the minimum version required by LegacyBridge according to its composer.json |
Moved to Issue: #94 |
Hello,
We're trying to migrate our former sites developed with eZ Publish 5.x in Legacy mode to eZ Platform 6.9.x with LegacyBridge 1.2.x.
I've noticed that the following folder has been moved from eZ Publish 5.x:
vendor/ezsystems/ezpublish-kernel/eZ/Publish/Core/MVC/Legacy
to
vendor/ezsystems/legacy-bridge/mvc
And the method hasInstance() has been removed from the class Kernel.php.
Could you give us the reason? Is it because it was used for Singleton Pattern which is considered now as an anti-pattern?
And is it possible to reintegrate it again?
The issue is that method is called in the following class:
vendor/ezsystems/legacy-bridge/bundle/Collector/TemplateDebugInfo.php
And other various classes as well.
Thank you in advance for your feedback.
Regards,
Quentin
Here is the method hasInstance extracted from eZ Publish 5.x :